Add hash for N integers #135745
Merged
Add hash for N integers #135745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
kkrik-es
reviewed
Oct 1, 2025
| for (long index = slot;; index = nextSlot(index, mask)) { | ||
| final long curId = id(index); | ||
| if (curId == -1) { // means unset | ||
| setId(index, id); |
There was a problem hiding this comment.
Shouldn't we be unsetting the first match that is not -1? I may misunderstood this.
There was a problem hiding this comment.
Good point. I copy-pasted this from other classes. I think the issue is the method name reset. This method is called after unsetting (in removeAndAdd) and is used to re-add to an empty slot instead.
kkrik-es
approved these changes
Oct 1, 2025
martijnvg
approved these changes
Oct 1, 2025
It depends on the number of grouping fields and rows. However, we need another BlockHash before we can see any improvement. |
|
Thanks @kkrik-es @martijnvg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackedValuesBlockHash can be very slow with a large number of groupings. I plan to introduce a BlockHash that generates a hash for each column, then uses IntNHash to generate the final hash ID. If a multi-value block is detected, we can fall back to PackedValuesBlockHash.